Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ui) Properly get display name when downloading search results #12720

Merged
merged 1 commit into from
Feb 26, 2025
Merged

fix(ui) Properly get display name when downloading search results #12720

merged 1 commit into from
Feb 26, 2025

Conversation

chriscollins3456
Copy link
Collaborator

There was a report where downloading results with groups in them were not getting the display name of the asset properly. This fixes that in v1 and v2 UIs for all entity types.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the product PR or Issue related to the DataHub UI/UX label Feb 24, 2025
@datahub-cyborg datahub-cyborg bot added the needs-review Label for PRs that need review from a maintainer. label Feb 24, 2025
@codecov Codecov
Copy link

codecov bot commented Feb 24, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...ared/components/styled/search/downloadAsCsvUtil.ts 0.00% 4 Missing ⚠️
...ared/components/styled/search/downloadAsCsvUtil.ts 0.00% 3 Missing ⚠️

❌ Your patch status has failed because the patch coverage (0.00%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage.

Files with missing lines Coverage Δ
...ared/components/styled/search/downloadAsCsvUtil.ts 26.92% <0.00%> (-0.27%) ⬇️
...ared/components/styled/search/downloadAsCsvUtil.ts 26.92% <0.00%> (-0.27%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8dfd8fb...6631eef. Read the comment docs.

@datahub-cyborg datahub-cyborg bot added pending-submitter-merge and removed needs-review Label for PRs that need review from a maintainer. labels Feb 25, 2025
@chriscollins3456 chriscollins3456 merged commit 815e688 into datahub-project:master Feb 26, 2025
209 of 216 checks passed
shirshanka pushed a commit to shirshanka/datahub that referenced this pull request Mar 3, 2025
@chriscollins3456 @shirshanka
fix(ui) Properly get display name when downloading search results (da…
369113a 
…tahub-project#12720)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jayacryl jayacryl jayacryl approved these changes

Assignees
No one assigned
Labels
pending-submitter-merge product PR or Issue related to the DataHub UI/UX
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chriscollins3456 @jayacryl